[webkit-reviews] review denied: [Bug 11250] File upload form
control isn't finished on Windows : [Attachment 11053] Patch
to make it work
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Sat Nov 4 13:14:14 PST 2006
Sam Weinig <sam.weinig at gmail.com> has denied Sam Weinig
<sam.weinig at gmail.com>'s request for review:
Bug 11250: File upload form control isn't finished on Windows
http://bugs.webkit.org/show_bug.cgi?id=11250
Attachment 11053: Patch to make it work
http://bugs.webkit.org/attachment.cgi?id=11053&action=edit
------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
I'm r- this due to a couple of style issues I see.
Please put the curly brace on the same line as the namespace declaration.
+namespace WebCore
+{
The curly brace for functions should go on it's own line and the content should
be indented 4 spaces. I'm also not sure the commented is need.
+// static
+PassRefPtr<FileChooser> FileChooser::create(Document* doc,
RenderFileUploadControl* control) {
+ return new FileChooser(doc, control);
+}
Otherwise, it's looking good.
More information about the webkit-reviews
mailing list