[webkit-reviews] review denied: [Bug 11508] Fix for bug 11504 broke 32-bit Windows builds : [Attachment 11369] patch v1

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sat Nov 4 00:36:05 PST 2006


Alexey Proskuryakov <ap at webkit.org> has denied Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 11508: Fix for bug 11504 broke 32-bit Windows builds
http://bugs.webkit.org/show_bug.cgi?id=11508

Attachment 11369: patch v1
http://bugs.webkit.org/attachment.cgi?id=11369&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Looks good to me, but r- for style issues - pointer types should be written
with no space between the type name and the *.

Perhaps it would make sense to merge all the templates into one
(FloatingPointBitValues or something).



More information about the webkit-reviews mailing list