[webkit-reviews] review denied: [Bug 11433] Fixes to get WebKit to run on windows : [Attachment 11350] Fix mapRect

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Nov 3 16:13:59 PST 2006

Maciej Stachowiak <mjs at apple.com> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 11433: Fixes to get WebKit to run on windows

Attachment 11350: Fix mapRect 

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
It's against the coding style guidelines to write single-line ifs with elses
like this:

if (px < enclosingRectMinX) enclosingRectMinX = px;
else if (px > enclosingRectMaxX) enclosingRectMaxX = px;
It would probably be simpler to write this by computing all four transformed
points and then using std::min and std::max to get the final coordinates, but
this way is fine too if you make it follow the style guidelines.

r- for the style issue.

More information about the webkit-reviews mailing list