[webkit-reviews] review requested: [Bug 9596] [Drosera] add a
function popup to the source pane : [Attachment 11367] Patch Revised
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Fri Nov 3 13:06:36 PST 2006
Vladimir Olexa (vladinecko) <vladimir.olexa at gmail.com> has asked for review:
Bug 9596: [Drosera] add a function popup to the source pane
http://bugs.webkit.org/show_bug.cgi?id=9596
Attachment 11367: Patch Revised
http://bugs.webkit.org/attachment.cgi?id=11367&action=edit
------- Additional Comments from Vladimir Olexa (vladinecko)
<vladimir.olexa at gmail.com>
- corrected else statements
- removed unnecessary variable
- removed unnecessary concatenation
- renamed var counter to functionKeywordOffset
- prototyped Element.removeChildren
- renamed placeholder text to <No selected symbol>
- replaced function name highlight with selection
More information about the webkit-reviews
mailing list