[webkit-reviews] review denied: [Bug 11484] Fixing rendering of line edits on Qt platform : [Attachment 11326] Use Qt style to render line edits

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Nov 1 15:23:46 PST 2006

Maciej Stachowiak <mjs at apple.com> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 11484: Fixing rendering of line edits on Qt platform

Attachment 11326: Use Qt style to render line edits

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Thanks for the patch!

The code changes in this patch look fine.

However, I do not think the commented code would be the right approach to
handling a style that leaves less room for contents. Instead, the RenderTheme
should adjust the border and padding when adjusting the style in such cases.
Also we usually put "FIXME:" as a prefix for things like this that need to be
looked at, not "###". r- to give you a chance to update the comment but I'll
happily r+ once that is done (or if you decide to leave it as-is -- not such a
big deal). Either way, just reflag it when ready.

More information about the webkit-reviews mailing list