[webkit-reviews] review granted: [Bug 11467] patch to make the kde support optional in the Qt build : [Attachment 11298] new patch to make compilation with kde optional

[bugzilla-request-daemon at macosforge.org]

Maciej Stachowiak <mjs at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 11467: patch to make the kde support optional in the Qt build
http://bugs.webkit.org/show_bug.cgi?id=11467

Attachment 11298: new patch to make compilation with kde optional
http://bugs.webkit.org/attachment.cgi?id=11298&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

Have you considered making a platform/kde directory and factoring some of this
so that there can be kde and pure-qt versions of some things?

Also, I would suggest refactoring the qt port to not need
ResourceHandleManager, the Qt and KDE versions of ResourceHandle could directly
each handle an underlying platform loader. This is the direction things are
moving in for the other ports. This is ok to land though.