[webkit-reviews] review denied: [Bug 11468] Group graphics related files in platform/graphics : [Attachment 11309] Updated patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Nov 1 09:45:35 PST 2006


Adam Roben <aroben at apple.com> has denied Adam Roben <aroben at apple.com>'s
request for review:
Bug 11468: Group graphics related files in platform/graphics
http://bugs.webkit.org/show_bug.cgi?id=11468

Attachment 11309: Updated patch
http://bugs.webkit.org/attachment.cgi?id=11309&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
With a semi-painful patch like this, it makes sense to do as complete a job as
possible. Can you move Icon and IntSizeHash into platform/graphics, and move
the Mac- and Win-specific implementation files to platform/graphics/mac and
platform/graphics/win? Then we won't have to deal with subsequent patches to
move those as well. Thanks!



More information about the webkit-reviews mailing list