[webkit-reviews] review denied: [Bug 9181] Complete DOMUIEvent Obj-C API to reflect UIEvent : [Attachment 8620] Patch to add DOMUIEventWithKeyState, DOMKeyboardEvent, DOMMouseRelatedEvent

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed May 31 14:14:32 PDT 2006


Geoffrey Garen <ggaren at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 9181: Complete DOMUIEvent Obj-C API to reflect UIEvent
http://bugzilla.opendarwin.org/show_bug.cgi?id=9181

Attachment 8620: Patch to add DOMUIEventWithKeyState, DOMKeyboardEvent,
DOMMouseRelatedEvent
http://bugzilla.opendarwin.org/attachment.cgi?id=8620&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Patch looks great.

A few things you need before landing:
1) Please add your copyright info to the files you've modified
2) Please add a ChangeLog entry (the prepare-ChangeLog script will help you).
3) How did you test? Can you add testing functionality to DumpRenderTree?



More information about the webkit-reviews mailing list