[webkit-reviews] review granted: [Bug 4249] SVG JavaScript bindings are busted in latest WebCore+SVG : [Attachment 8610] Much better patch, ready for review.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed May 31 08:14:22 PDT 2006


Anders Carlsson <andersca at mac.com> has granted Anders Carlsson
<andersca at mac.com>'s request for review:
Bug 4249: SVG JavaScript bindings are busted in latest WebCore+SVG
http://bugzilla.opendarwin.org/show_bug.cgi?id=4249

Attachment 8610: Much better patch, ready for review.
http://bugzilla.opendarwin.org/attachment.cgi?id=8610&action=edit

------- Additional Comments from Anders Carlsson <andersca at mac.com>
Some comments:

-    if (@{$dataNode->parents} > 1) {
-	 die "A class can't have more than one parent";
-    }
+    #if (@{$dataNode->parents} > 1) {
+    #	  die "A class can't have more than one parent";
+    #}

There should be a comment explaining why this is commented out.

I think the IDL files should be LGPL



More information about the webkit-reviews mailing list