[webkit-reviews] review denied: [Bug 8223] WebKit fails to update style on element via DOM : [Attachment 8577] Now with testcase

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed May 31 00:22:41 PDT 2006


Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 8223: WebKit fails to update style on element via DOM
http://bugzilla.opendarwin.org/show_bug.cgi?id=8223

Attachment 8577: Now with testcase
http://bugzilla.opendarwin.org/attachment.cgi?id=8577&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
The Obj-C bindings need fixing too.  They all have the same bug (repeated over
and over again).

- (void)setBackgroundRepeat:(NSString *)backgroundRepeat
{
    [self setProperty:@"background-repeat" :backgroundRepeat :@""];
}

The empty string is passed for priority.  You need to make an Obj-C method for
your new setProperty call and then change all the callers to use that instead.



More information about the webkit-reviews mailing list