[webkit-reviews] review denied: [Bug 9114] The file performance_test_results.html is missing after running atf : [Attachment 8609] Added Changlog to previous patch

[bugzilla-request-daemon at opendarwin.org]

Zalan Bujtas <zbujtas at gmail.com> has denied Zalan Bujtas <zbujtas at gmail.com>'s
request for review:
Bug 9114: The file performance_test_results.html is missing after running atf
http://bugzilla.opendarwin.org/show_bug.cgi?id=9114

Attachment 8609: Added Changlog to previous patch
http://bugzilla.opendarwin.org/attachment.cgi?id=8609&action=edit

------- Additional Comments from Zalan Bujtas <zbujtas at gmail.com>
>if ( !err && 
please check for err == KErrNone (symbian coding convetion)

>numTestsRun->Des().Length()
use numTestsRun->Length() instead. ->Des() creates a copy of that descriptor.

>PrepPerformanceResultsFileL()
cleanupCount variable is not needed.

>(TDesC&)KRunAllTests() 
change DoAutomatedTestsActionL signature from TDesC& aActionString to const
TDesC& aActionString. no need for typecast.