[webkit-reviews] review denied: [Bug 9135] unable to cancel page load : [Attachment 8568] fix softkey+cancel

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue May 30 10:32:41 PDT 2006

David Carson <david.carson at nokia.com> has denied David Carson
<david.carson at nokia.com>'s request for review:
Bug 9135: unable to cancel page load

Attachment 8568: fix softkey+cancel

------- Additional Comments from David Carson <david.carson at nokia.com>
There are a number of places where no changes have been made, but they are
included in the patch. They don't need to be part of the patch.
It seems that tabs were used in WebUiWindowContainer.cpp, spaces should be used
so that it is consistent with the rest of the file. See also the first bullet
of: http://webkit.opendarwin.org/coding/coding-style.html
I am not sure if there is going to be a ChangeLog for the UI, but there should
be. See: http://webkit.opendarwin.org/coding/contributing.html

More information about the webkit-reviews mailing list