[webkit-reviews] review cancelled: [Bug 6755] CSS3: Borders rounded with border-radius don't draw the roundings : [Attachment 8527] Next round...still not ready to land

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri May 26 14:55:40 PDT 2006


Beth Dakin <bdakin at apple.com> has cancelled Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 6755: CSS3: Borders rounded with border-radius don't draw the roundings
http://bugzilla.opendarwin.org/show_bug.cgi?id=6755

Attachment 8527: Next round...still not ready to land
http://bugzilla.opendarwin.org/attachment.cgi?id=8527&action=edit

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Okay here is my latest version of the patch. I feel much better about this one
than either of the previous two. This patch also adds a clip inside the arc so
that some edge cases (like 1 px borders) will now look correct. There are two
things I would like to discuss about this patch before it is landed (in
addition to any comments people have, of course). First, antialiasing yes or
no? This patch that i am posting now leaves antialiasing on, but I have been
switching it on and off throughout working on this bug, and I can't decide
which is better. When there is not background color, the borders themselves
look significantly better with antialiasing on, but some background colors mix
with the antialiased border arcs to make the corners looks a little smudgy. In
the end, i may just have to sit down with Hyatt or someone and show both
versions and decide which we prefer. The other thing is dotted and dashed. they
aren't perfect but I am not sure how else to do them. It is also possible that
we want to just file that as a follow-up bug since getting those styles just
right isn't necessarily our priority right now.



More information about the webkit-reviews mailing list