[webkit-reviews] review granted: [Bug 3379] attr(X) does not work : [Attachment 8550] addressed comments

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri May 26 11:30:43 PDT 2006

Dave Hyatt <hyatt at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 3379: attr(X) does not work

Attachment 8550: addressed comments

------- Additional Comments from Dave Hyatt <hyatt at apple.com>

Yeah, we should probably rename the m_selectorAttrs variable (and the method
that queries it) at some point.

Another problem I notice is that m_selectorAttrs was coded just to use
localName.  This make it a little less precise than it could be (if it were to
use the full qualified name instead).

More information about the webkit-reviews mailing list