[webkit-reviews] review requested: [Bug 3379] attr(X) does not work
: [Attachment 8550] addressed comments
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Fri May 26 03:27:49 PDT 2006
Rémi Zara <remi_zara at mac.com> has asked for review:
Bug 3379: attr(X) does not work
http://bugzilla.opendarwin.org/show_bug.cgi?id=3379
Attachment 8550: addressed comments
http://bugzilla.opendarwin.org/attachment.cgi?id=8550&action=edit
------- Additional Comments from Rémi Zara <remi_zara at mac.com>
Addressed comments, but I'm not sure if I did it right:
* I'm not sure that "if (style->styleType()==RenderStyle::NOPSEUDO)" is ok
* I feel like abusing m_selectorAttrs for point (2) of the review, but it
works. So either it works by chance, or maybe this class member should be
renamed, maybe to m_affectingAttrs (attributes affecting this style, either in
selector or properties) ?
More information about the webkit-reviews
mailing list