[webkit-reviews] review denied: [Bug 3379] attr(X) does not work : [Attachment 8538] Add a "unique" bit to RenderStyle

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu May 25 22:59:25 PDT 2006

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 3379: attr(X) does not work

Attachment 8538: Add a "unique" bit to RenderStyle

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This is really close.  I have two remaining concerns.

(1) Hardcoding of


In CSS3 you'll be able to use the content property without it being in
:before/:after, so I think it's better to actually check what you're matching. 
If you're matching some pseudo-element, then you need to make parentStyle
unique, but if you're not, then you need to make style unique instead.

(2) This second concern could be handled by another patch but is easy to add I
think.	Since this patch was last worked on Rob landed some code for us to
respond to dynamic attribute changes by registering which attribute affect
style.	The attr() construct isn't doing this yet though, so dynamically
changing attributes that don't already cause a setChanged() will fail.

Addressing (1) is enough for me to +.  Addressing (2) is extra credit. :)

More information about the webkit-reviews mailing list