[webkit-reviews] review denied: [Bug 4127] WebCore doesn't support Media Queries (CSS3 module) : [Attachment 8508] Revised CSS Media Queries patch including testcases

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed May 24 13:08:19 PDT 2006


Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 4127: WebCore doesn't support Media Queries (CSS3 module)
http://bugzilla.opendarwin.org/show_bug.cgi?id=4127

Attachment 8508: Revised CSS Media Queries patch including testcases
http://bugzilla.opendarwin.org/attachment.cgi?id=8508&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Great!	I have a few comments/suggestions:

(1) Rename adjustFont to updateFont.
(2) Rename matchUAAndPrintRules to matchUARules.
(3) The defaultStyleForRoot method feels really gross to me (the way it has to
duplicate the style resolution process).  Is there no way to just compute this
style during the normal process?



More information about the webkit-reviews mailing list