[webkit-reviews] review granted: [Bug 8969] REGRESSION: typing in textfield repaints whole web page at gamefaqs.com : [Attachment 8483] Revised patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed May 24 12:17:21 PDT 2006


Dave Hyatt <hyatt at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 8969: REGRESSION: typing in textfield repaints whole web page at
gamefaqs.com
http://bugzilla.opendarwin.org/show_bug.cgi?id=8969

Attachment 8483: Revised patch
http://bugzilla.opendarwin.org/attachment.cgi?id=8483&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This is ready for text fields.	I do see one issue if we do try to extend this
to overflow sections...

-    root->updateWidgetPositions();
+    if (!subtree)
+	 static_cast<RenderCanvas*>(root)->updateWidgetPositions();

If the subtree contains widgets, then you'll need to run updateWidgetPositions
but only on the widgets in the subtree.



More information about the webkit-reviews mailing list