[webkit-reviews] review denied: [Bug 8455] selectedIndex for a select after a Form reset() has wrong value : [Attachment 8491] First attempt

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue May 23 13:38:35 PDT 2006


Geoffrey Garen <ggaren at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 8455: selectedIndex for a select after a Form reset() has wrong value
http://bugzilla.opendarwin.org/show_bug.cgi?id=8455

Attachment 8491: First attempt
http://bugzilla.opendarwin.org/attachment.cgi?id=8491&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
It should be sufficient to keep a flag tracking whether any of the option
elements had the 'selected' attribute set, and select option 0 if none did.
That would avoid the call to recalcListItems().

I'm going to mark this r-, in case you want to submit the 'lighter' solution.



More information about the webkit-reviews mailing list