[webkit-reviews] review requested: [Bug 6755] CSS3: Borders rounded with border-radius don't draw the roundings : [Attachment 8484] First shot at border-radius....(incomplete)

[bugzilla-request-daemon at opendarwin.org]

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 6755: CSS3: Borders rounded with border-radius don't draw the roundings
http://bugzilla.opendarwin.org/show_bug.cgi?id=6755

Attachment 8484: First shot at border-radius....(incomplete)
http://bugzilla.opendarwin.org/attachment.cgi?id=8484&action=edit

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Here is a patch for border-radius. Several things about this patch:

1. It is incomplete. It does not yet draw the inset, groove, ridge, or outset
styles.
2. My drawBorderArc() function is based largely on drawBorder() but right now,
it ignores all cases where adjbw1 and adjbw2 are nonzero. This is mostly
because I don't understand what adjbw1 and adjbw2 are just yet...need to talk
to Hyatt or someone about that.
3. I took over the drawArc() function in GraphicsContext to make it specific to
what I needed. I think this is fine because drawArc() is never actually called
from anywhere in WebCore outside of this patch.

Okay, I think that's mostly it. Mainly I am just looking for feedback on what I
have right now.