[webkit-reviews] review granted: [Bug 8983] Autogenerate another 22 HTML classes : [Attachment 8398] Patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu May 18 16:14:29 PDT 2006

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 8983: Autogenerate another 22 HTML classes

Attachment 8398: Patch

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
In general this looks great.

We shoudl make sure to land a test for every place in which we differ from the
spec.  In autogenerating other classes I found that the dom 2 html spec changed
the type of several attributes, which might be what you're noticing in these as

Second, you also should fix the style Document *doc instead of Document* doc,
in HTMLBodyElement.cpp

With those additional test cases to cover the places where we differ from the
spec, you're good to land.

More information about the webkit-reviews mailing list