[webkit-reviews] review granted: [Bug 8937] EncodingMap uses 0 as its empty value but 0 is a valid TextEncodingID : [Attachment 8391] Patch w/change log

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8937: EncodingMap uses 0 as its empty value but 0 is a valid TextEncodingID
http://bugzilla.opendarwin.org/show_bug.cgi?id=8937

Attachment 8391: Patch w/change log
http://bugzilla.opendarwin.org/attachment.cgi?id=8391&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks great, r=me.

One comment for the future. When you have an assert that has an && in it, it's
usually better to have two asserts. That way each one has a smaller expression
in it, and also if one fails you know which half failed.