[webkit-reviews] review denied: [Bug 8937] EncodingMap uses 0 as its empty value but 0 is a valid TextEncodingID : [Attachment 8367] A fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed May 17 22:00:38 PDT 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8937: EncodingMap uses 0 as its empty value but 0 is a valid TextEncodingID
http://bugzilla.opendarwin.org/show_bug.cgi?id=8937

Attachment 8367: A fix
http://bugzilla.opendarwin.org/attachment.cgi?id=8367&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Actually, the specialization of the HashKeyStorageTraits can and should be
removed entirely if we have to change the empty value. The reason that's there
is to make the hash table implementation get shared. But that sharing can't
take place if the traits are not the standard traits for the integer type.

Otherwise, this patch looks fine.



More information about the webkit-reviews mailing list