[webkit-reviews] review granted: [Bug 8331] DOMNodeLists returned
to Objective-C are not properly wrapped : [Attachment 8343]
patch, please review
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Tue May 16 10:16:30 PDT 2006
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8331: DOMNodeLists returned to Objective-C are not properly wrapped
http://bugzilla.opendarwin.org/show_bug.cgi?id=8331
Attachment 8343: patch, please review
http://bugzilla.opendarwin.org/attachment.cgi?id=8343&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Lets not check in the RGBColor, Rect, and Counter stuff commented-out. I don't
like landing code with #if 0 around it.
Best way to keep track of that loose end is to write a bug report about it.
In valueForKey: it seems to me that we should be calling super in the
"!isSafeScript" case too.
Otherwise, this patch looks perfect!
I think I'm going to review+ this even though it has the #if 0 in it.
More information about the webkit-reviews
mailing list