[webkit-reviews] review requested: [Bug 5264] document.createElementNS() should not allow to insert a second <html> element : [Attachment 8328] Different approach

Mon May 15 13:37:07 PDT 2006

Rob Buis <rwlbuis at xs4all.nl> has asked	for review:
Bug 5264: document.createElementNS() should not allow to insert a second <html>
element
http://bugzilla.opendarwin.org/show_bug.cgi?id=5264

Attachment 8328: Different approach
http://bugzilla.opendarwin.org/attachment.cgi?id=8328&action=edit

------- Additional Comments from Rob Buis <rwlbuis at xs4all.nl>
Hi Darin,

I think it will be hard to merge some of the functions. For instance
HTMLElement::childAllowed
really seems to be useful only for parsing, not for dom usage. In the new patch
I move the two checks
from Document::childallowed to Document::childTypeAllowed. That means for
calling childAllowed
on Document it behaves as before, for Document::childTypeAllowed it adds the
two checks.
The changed test results are official dom cases that now pass, except
documentnormalizedocument10.xhtml, which also "fails" in firefox. I think that
test is broken though,
the others probably need updated test results.
Firefox behaves correctly, it throws the exception.
Win IE does not run the testcase, it says:

Line 3
Char 3
Error: Object doesn't support this property or method

Cheers,

Rob.