[webkit-reviews] review requested: [Bug 8870] Crash typing in Yahoo auto-complete widget. : [Attachment 8281] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat May 13 06:20:25 PDT 2006

Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 8870: Crash typing in Yahoo auto-complete widget.

Attachment 8281: proposed fix

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
This is a stack overflow, and it has nothing to do with how WebKit invokes PCRE
- it's also reproducible with pcretest, versions 6.1 (used in WebKit) and 6.6

PCRE has a mode for systems with limited stack, where it no longer uses
recursion (at the cost of some performance, reportedly). There are also some
limits that can make deep recursion fail with an error, but I don't see how we
could use them, as long as we want to work with Yahoo widgets.

This patch just defines NO_RECURSE. There is no noticeable delay when opening
the test.

More information about the webkit-reviews mailing list