[webkit-reviews] review requested: [Bug 7156] TinyMCE: Links are actually activated in editable area, not editable. : [Attachment 8257] Patch with simple fix

[bugzilla-request-daemon at opendarwin.org]

Timothy Hatcher <timothy at hatcher.name> has asked  for review:
Bug 7156: TinyMCE: Links are actually activated in editable area, not editable.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7156

Attachment 8257: Patch with simple fix
http://bugzilla.opendarwin.org/attachment.cgi?id=8257&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
	Links in editable areas will not activate or perform a navigation
	change (on par with WinIE and Firefox.) To visit the link
	you can shift-click. Manual test added.

	* css/cssstyleselector.cpp:
	(WebCore::CSSStyleSelector::adjustRenderStyle):
	* html/html_inlineimpl.cpp:
	(WebCore::HTMLAnchorElement::defaultEventHandler):
	(WebCore::HTMLAnchorElement::setActive):
	* html/html_inlineimpl.h:
	* manual-tests/contenteditable-link.html: Added.
	* page/FrameView.cpp:
	(WebCore::selectCursor):

A more complex fix to allow editing of the href is being talked about, but this
lets us behave like IE and Firefox.