[webkit-reviews] review denied: [Bug 8393] <br>s created by createMarkup aren't valid xhtml : [Attachment 8256] Patch + Layout Tests + Detailed Changelog Entry

[bugzilla-request-daemon at opendarwin.org]

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 8393: <br>s created by createMarkup aren't valid xhtml
http://bugzilla.opendarwin.org/show_bug.cgi?id=8393

Attachment 8256: Patch + Layout Tests + Detailed Changelog Entry
http://bugzilla.opendarwin.org/attachment.cgi?id=8256&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Elements and attributes in XML are case-sensitive.  For generic non-HTML
elements, the output should not be lower-cased. It should be left alone.

For HTML elements, nodeName has been hacked to return an upper-case string.  In
both HTML and XHTML, this is not what should be used for HTML elements.  We
want to output in lower-case for HTML elements regardless of document type.

Rather than having to .lower() over and over it would be better to put an
accessor on HTML element that didn't .upper() the result.  

Right now you're calling nodeName() which uppers and then .lowering that.