[webkit-reviews] review granted: [Bug 7838] Add support for mozilla-style node constructors as properties of the window object : [Attachment 8226] Patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 7838: Add support for mozilla-style node constructors as properties of the
window object
http://bugzilla.opendarwin.org/show_bug.cgi?id=7838

Attachment 8226: Patch
http://bugzilla.opendarwin.org/attachment.cgi?id=8226&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I'm not happy about these classes that differ only in namespace; I hope that's
a temporary situation.

For other classes I like to name the hand-coded ones differently, for example
XXXBase. Worth considering if we have to leave the code like this for any
length of time.

We also might want to use a new approach for half-generated classes where we
can hand-write some functions rather than hand-writing an entire class, and
teach the auto-generation code to write out declarations for the functions even
if the functions themselves are hand-coded.

There should be a layout test for the new constructor objects, I don't see that
here.

Assuming you add that layout test, r=me.