[webkit-reviews] review granted: [Bug 8813] Optimizing +[DOMNode _nodeWith:] : [Attachment 8191] Optimization

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8813: Optimizing +[DOMNode _nodeWith:]
http://bugzilla.opendarwin.org/show_bug.cgi?id=8813

Attachment 8191: Optimization
http://bugzilla.opendarwin.org/attachment.cgi?id=8191&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks great, r=me.

Some minor comments that should not prvent us landing this:

+static ObjcClassMap *objcClassMap;

The * should be next to the type rather than the variable.

I think ObjC is clearer than Objc.

+    // Populate it with DOM Element classes.

I would say "element" not "Element".

+    addObjcClassForTag(htmlTag, [DOMHTMLHtmlElement class]);

Sorting these alphabetically would make it easier to see if something is in the
list or not.