[webkit-reviews] review granted: [Bug 8808] WebCore should handle text files : [Attachment 8186] Patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue May 9 11:35:48 PDT 2006

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8808: WebCore should handle text files

Attachment 8186: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
+    PassRefPtr<TextDocument> createTextDocument(FrameView* v = 0);

No need for the "v" there.

Why create separate text nodes for each piece of data written? Maybe instead we
should create just one large text node.

Why create a "pre" element? Couldn't we just put the text into the body and use
CSS to style as we like?

+TextDocument::TextDocument(DOMImplementation *_implementation, FrameView *v)

Please put * next to the type name. Please don't use an underscore prefix in
new code.

I do think the list of unsupported text MIME types should go into WebCore.

This looks ready to go to me. r=me

More information about the webkit-reviews mailing list