[webkit-reviews] review requested: [Bug 6282] Adding new Option
with new Option(text, value, defaultSelected,
selected) fails to update selectedIndex : [Attachment 8172] New patch
after feedback from Darin
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon May 8 13:51:01 PDT 2006
Rob Buis <rwlbuis at xs4all.nl> has asked for review:
Bug 6282: Adding new Option with new Option(text, value, defaultSelected,
selected) fails to update selectedIndex
http://bugzilla.opendarwin.org/show_bug.cgi?id=6282
Attachment 8172: New patch after feedback from Darin
http://bugzilla.opendarwin.org/attachment.cgi?id=8172&action=edit
------- Additional Comments from Rob Buis <rwlbuis at xs4all.nl>
Hi Darin,
This new patch tries to solve some of the issues you raised. I agree with
your points about the js binding trying to do too much.
If you can give some pointers on the needed testcase I can add it quickly too.
Note that there already is a test for dynamic option replacement, so we may
just need 1
for dynamic option additions?
Cheers,
Rob.
More information about the webkit-reviews
mailing list