[webkit-reviews] review granted: [Bug 6638] Support Mozilla's
XPathEvaluator object. : [Attachment 8163] Address Darin's comments
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon May 8 13:35:06 PDT 2006
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 6638: Support Mozilla's XPathEvaluator object.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6638
Attachment 8163: Address Darin's comments
http://bugzilla.opendarwin.org/attachment.cgi?id=8163&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Seems that unregisterString calls are always paired with a delete.
+ return double();
That's just a "return 0" in sheep's clothing.
+ return bool();
And this is just a "return false".
+ return m_bool ? 1 : 0;
That's the same as return m_bool.
+ else if (m_number == 0)
+ return "0";
Do we really need a special case for that? What *does* DeprecatedString::number
do with NaN, 0, and infinity?
These are a few things that could still be improved, but I think this is ready
to go.
r=me
More information about the webkit-reviews
mailing list