[webkit-reviews] review requested: [Bug 7492] CSS Attribute Selectors fail when the setAttribute() method is used to create an attribute and the attibute name is not Class or ID. : [Attachment 8165] Proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon May 8 06:50:33 PDT 2006


Rob Buis <rwlbuis at xs4all.nl> has asked	for review:
Bug 7492: CSS Attribute Selectors fail when the setAttribute() method is used
to create an attribute and the attibute name is not Class or ID.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7492

Attachment 8165: Proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=8165&action=edit

------- Additional Comments from Rob Buis <rwlbuis at xs4all.nl>
The patch simply checks on attribute change whether there are any attribute
selectors, if
so it marks the element as changed. It seems to me this is not needed for
mapped attributes,
hence the entry == eNone check.
Cheers,

Rob.



More information about the webkit-reviews mailing list