[webkit-reviews] review denied: [Bug 8132] CSS parser sometimes accepts real number as integer : [Attachment 8151] Updated patch after darins feedback

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun May 7 18:50:20 PDT 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8132: CSS parser sometimes accepts real number as integer
http://bugzilla.opendarwin.org/show_bug.cgi?id=8132

Attachment 8151: Updated patch after darins feedback
http://bugzilla.opendarwin.org/attachment.cgi?id=8151&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+  | IMPORT_SYM maybe_space string_or_uri maybe_space maybe_media_list {
+	 $$ = static_cast<CSSParser *>(parser)->createImportRule($3, $5);
+    }

What does this change have to do with the bug you're fixing? Looks like
something else you were working on?

I think it's quite ugly that isInt is there all the time, but only used for the
CSS_NUMBER case. Might need at least a comment to make that clear.

review- just because of the IMPORT_SYM line; no need for more review, but we
need a patch without that change



More information about the webkit-reviews mailing list