[webkit-reviews] review requested: [Bug 8769] TextEncoding::fromUnicode() - support non-BMP characters and convert to NFC : [Attachment 8154] update a failing test

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun May 7 14:29:50 PDT 2006


Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 8769: TextEncoding::fromUnicode() - support non-BMP characters and convert
to NFC
http://bugzilla.opendarwin.org/show_bug.cgi?id=8769

Attachment 8154: update a failing test
http://bugzilla.opendarwin.org/attachment.cgi?id=8154&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
I'm suggesting to update the test case to the new results. Since we're supposed
to normalize input to NFC anyway, the change is a slight improvement (also,
standard Mac fonts don't have glyphs for U+2328 or U+2329, but do have glyphs
for the equivalents).

OTOH, processing of entities becomes pretty inconsistent now, and that's ugly.
An alternative fix would be to modify getXHTMLEntity() not to do normalization.



More information about the webkit-reviews mailing list