[webkit-reviews] review denied: [Bug 8132] CSS parser sometimes accepts real number as integer : [Attachment 8141] Updated patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun May 7 10:28:14 PDT 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8132: CSS parser sometimes accepts real number as integer

Attachment 8141: Updated patch

------- Additional Comments from Darin Adler <darin at apple.com>
 num		 [0-9]+|[0-9]*"."[0-9]+
+intnum 	 [0-9]+|[0-9]*

This looks wrong to me. [0-9]+ would be correct, the [0-9]* part is not
relevant nor do we need a "|".

I'm also unclear on how flex handles the ambiguity since both {num} and
{intnum} can match the same thing. We might need to rearrange the regular
expressions so that is not the case.

I suggest using INTEGER instead of INTNUMBER and perhaps changing the name of
NUMBER to something like FLOAT.

We need a test case. We don't check in bug fixes without test cases.

More information about the webkit-reviews mailing list