[webkit-reviews] review requested: [Bug 8732] backgrounds with background-size and background-origin do not always lay out correctly : [Attachment 8104] Patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu May 4 09:57:21 PDT 2006


Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 8732: backgrounds with background-size and background-origin do not always
lay out correctly
http://bugzilla.opendarwin.org/show_bug.cgi?id=8732

Attachment 8104: Patch
http://bugzilla.opendarwin.org/attachment.cgi?id=8104&action=edit

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Here is a patch that fixes the problem. This patch generally re-arranges things
so that the scaledImageWidth and scaledImageHeight are calculated at the
beginning and taken into consideration when calculating cx, cy, cw, ch, sx, and
sy. This means that we no longer have to scale the source point over in the
image code and that we can remove some of the weird if-clauses that adjusted
the c-values when the scale sizes were computed after the fact.



More information about the webkit-reviews mailing list