[webkit-reviews] review granted: [Bug 6608] REGRESSION: Line
disappears when deleting : [Attachment 7391] patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Thu Mar 30 08:35:18 PST 2006
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 6608: REGRESSION: Line disappears when deleting
http://bugzilla.opendarwin.org/show_bug.cgi?id=6608
Attachment 7391: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=7391&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Are you guaranteed that removing a node won't cause it's parent to be deref'd?
If not, the Node* might need to be RefPtr<Node>.
+ void removeNodeAndPruneAncestors(WebCore::Node* node);
+ void prune(WebCore::Node* node);
No need for WebCore:: prefixes here.
r=me
More information about the webkit-reviews
mailing list