[webkit-reviews] review denied: [Bug 7989] Win32: User Agent shouldn't be hardcoded in TransferJobWin : [Attachment 7335] Follows guidelines, adds copyright and changelog

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 7989: Win32: User Agent shouldn't be hardcoded in TransferJobWin
http://bugzilla.opendarwin.org/show_bug.cgi?id=7989

Attachment 7335: Follows guidelines, adds copyright and changelog
http://bugzilla.opendarwin.org/attachment.cgi?id=7335&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This uses String::ascii, but this is what PlatformString.h says:

#ifndef NDEBUG
    // For debugging only, leaks memory.
    const char *ascii() const;
#endif

So this won't even compile when NDEBUG is set. We need a solution that doesn't
involve the ascii() function.

A short term hack would be to use DeprecatedString's ascii() function. A better
fix would be to add an appropriate conversion for String for this case; perhaps
a way to convert to an ASCII string that doesn't leak memory or a way to
convert to a Windows wchar_t* so we can use InternetOpen rather than
InternetOpenA?