[webkit-reviews] review granted: [Bug 8044] WebKit Visual Studio 2005 project shouldn't use the SolutionDir : [Attachment 7365] Makes projects use project directory

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Mar 29 03:31:58 PST 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8044: WebKit Visual Studio 2005 project shouldn't use the SolutionDir
http://bugzilla.opendarwin.org/show_bug.cgi?id=8044

Attachment 7365: Makes projects use project directory
http://bugzilla.opendarwin.org/attachment.cgi?id=7365&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Seems fine. Being relative to the project at all is probably wrong for the long
term, but this makes us less dependent on the solution structure, which is
nice.

Please don't use tabs in your ChangeLog files though. We can't commit them with
tabs and it just makes extra work for whoever lands the patch.



More information about the webkit-reviews mailing list