[webkit-reviews] review denied: [Bug 7964] 8F36 Regression: crash in malloc_consolidate if you use a .PAC file : [Attachment 7348] Fix 2

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Mar 28 10:38:45 PST 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 7964: 8F36 Regression: crash in malloc_consolidate if you use a .PAC file

Attachment 7348: Fix 2

------- Additional Comments from Darin Adler <darin at apple.com>
Instead of having m_destructorIsThreadSafe be protected, a nicer design would
be to pass the bool into the JSCell and JSObject constructors. You could have
empty constructors that would set to true, and an explicit constructor that
takes a bool.

I think it's a bit ugly that currentThreadIsMainThread is in FastMalloc.h; we
need that bit even when not using FastMalloc. An in fact I don't see where it's
defined for the USE_SYSTEM_MALLOC case, so I think debug builds will fail!

Are you sure that the usedCells == CELLS_PER_BLOCK special case was not
helping? Did it speed things up to remove it?

review- because of the currentThreadIsMainThread issue.

More information about the webkit-reviews mailing list