[webkit-reviews] review granted: [Bug 7152] REGRESSION: Select All does not highlight table if it's last in the document : [Attachment 7322] patch

[bugzilla-request-daemon at opendarwin.org]

Maciej Stachowiak <mjs at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 7152: REGRESSION: Select All does not highlight table if it's last in the
document
http://bugzilla.opendarwin.org/show_bug.cgi?id=7152

Attachment 7322: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=7322&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
+	 (WebCore::RenderObject::nextInPreOrder): Renamed from nextRenderer,
cleaned up the logic a little.
+	 (WebCore::RenderObject::nextInPreOrderAfterChildren): Added, like
Node::traverseNextSibling.

Might be good to call these traverseNext[Renderer] and traverseNextSibling for
naming consistency with the Node ones.

+	 (WebCore::RenderObject::previousInPreOrder): Renamed from
previousRenderer.

Likewise, traversePrevious[Renderer]

On the other hand, maybe your new names are more clear and should be used for
Node as well.

+RenderObject* objectAfterPosition(RenderObject* object, unsigned offset)

I would call this rendererAfterPosition or something.

Other than the naming nitpicks, r=me