[webkit-reviews] review denied: [Bug 7984] ifdef win32 specific
code in GraphicsContextCairo.cpp : [Attachment 7312] Patch
with WIN32 ifdefs and LINUX ifdefs
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Mar 27 20:12:35 PST 2006
Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 7984: ifdef win32 specific code in GraphicsContextCairo.cpp
http://bugzilla.opendarwin.org/show_bug.cgi?id=7984
Attachment 7312: Patch with WIN32 ifdefs and LINUX ifdefs
http://bugzilla.opendarwin.org/attachment.cgi?id=7312&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
These should be changed to use PLATFORM(WIN_OS) and PLATFORM(LINUX_OS) macros.
They also should just be made into an ||
#if PLATFORM(WIN_OS) || PLATFORM(LINUX_OS)
cairo_t* platformContext() const
#endif
also, we do not commit commented out code, so
//typedef struct _GdkDrawable GdkDrawable
It looks like in total you're not adding anything to the file. You should just
change the required #if lines to include linux in an or instead of duplicating
them.
More information about the webkit-reviews
mailing list