[webkit-reviews] review granted: [Bug 8009] Drag DeprecatedString 3 steps closer to its grave... : [Attachment 7329] Replace a bunch more DeprecatedString with String

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 8009: Drag DeprecatedString 3 steps closer to its grave...
http://bugzilla.opendarwin.org/show_bug.cgi?id=8009

Attachment 7329: Replace a bunch more DeprecatedString with String
http://bugzilla.opendarwin.org/attachment.cgi?id=7329&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Why the limit of 2048 on buffer size of sprintf on WIN_OS?

+    Vector<char> buffer;

Should use Vector<char, 256> for better performance here.

I think that String's sprintf should return a String instead of being a
function that mutates an existing string. Maybe it should be a free function
called StringPrintF or StringFormat?

Otherwise, r=me.