[webkit-reviews] review denied: [Bug 7989] Win32: User Agent shouldn't be hardcoded in TransferJobWin : [Attachment 7336] Spinneret part of fix.. updated to follow guidelines

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Mar 27 11:07:21 PST 2006


Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 7989: Win32: User Agent shouldn't be hardcoded in TransferJobWin
http://bugzilla.opendarwin.org/show_bug.cgi?id=7989

Attachment 7336: Spinneret part of fix.. updated to follow guidelines
http://bugzilla.opendarwin.org/attachment.cgi?id=7336&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This is the wrong place for this code.

The WebView should be the one setting the main frame on the page.

Also the Document owns a doc loader, you shouldn't create one in Frame like
that.  Also deleting the DocLoader right after calling start() will just cause
things to crash.



More information about the webkit-reviews mailing list