[webkit-reviews] review requested: [Bug 7855] REGRESSION:
document.open() in a script added through document.write()
causes a crash : [Attachment 7339] proposed fix
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Mar 27 10:47:58 PST 2006
Alexey Proskuryakov <ap at nypop.com> has asked Maciej Stachowiak <mjs at apple.com>
for review:
Bug 7855: REGRESSION: document.open() in a script added through
document.write() causes a crash
http://bugzilla.opendarwin.org/show_bug.cgi?id=7855
Attachment 7339: proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=7339&action=edit
------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
Discussed this with Geoffrey on IRC. For #1, just changed the bool variable
name to be more specific. For #2, I think that re-creating newNodes right after
deleting it simplifies the check in the constructor (saving a branch) and makes
the logic simpler.
I guess that the bigger question is if this is needed at all, given that Maciej
has just fixed this bug independently.
More information about the webkit-reviews
mailing list