[webkit-reviews] review denied: [Bug 7959] generate-derived-sources
script assumes environment variables : [Attachment 7311]
Default environment variables
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Mar 26 22:48:50 PST 2006
Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 7959: generate-derived-sources script assumes environment variables
http://bugzilla.opendarwin.org/show_bug.cgi?id=7959
Attachment 7311: Default environment variables
http://bugzilla.opendarwin.org/attachment.cgi?id=7311&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
It looks like other people said this, but I don't think that putting in default
values for this is a good idea. This script is supposed to be invoked by a
build script of some sort, part of the Xcode or Visual Studio project, or from
a Makefile. It should not be invoked by hand.
It would be OK to add something that detects this case and writes out an error
message.
More information about the webkit-reviews
mailing list