[webkit-reviews] review denied: [Bug 7989] Win32: User Agent shouldn't be hardcoded in TransferJobWin : [Attachment 7303] Spinneret part of fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Mar 26 02:57:01 PST 2006


Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 7989: Win32: User Agent shouldn't be hardcoded in TransferJobWin
http://bugzilla.opendarwin.org/show_bug.cgi?id=7989

Attachment 7303: Spinneret part of fix
http://bugzilla.opendarwin.org/attachment.cgi?id=7303&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This patch fails to follow style guidelines, has tabs, is missing a copyright
header, and changelog.

It also looks like it leaks a DocLoader on every request.

Otherwise the code itself looks sane.



More information about the webkit-reviews mailing list