[webkit-reviews] review denied: [Bug 7951] REGRESSION: Safari crashes when printing a google map w/directions : [Attachment 7269] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Mar 24 15:56:42 PST 2006


Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 7951: REGRESSION: Safari crashes when printing a google map w/directions
http://bugzilla.opendarwin.org/show_bug.cgi?id=7951

Attachment 7269: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=7269&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Sorry to flip-flop.  I do think doing this in the cell is slightly better
because

(a) You avoid making recalcMinMaxWidths virtual

and

(b) Your current patch does the section recalc even when the table may not need
to recompute its min/max width (or cells may not etc.)



More information about the webkit-reviews mailing list